Separate check/radio icon from menu item icon #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadelessFox
force-pushed
the
menuitem-separate-check-and-icon
branch
2 times, most recently
from
7890578 to
b1c3272
Compare
ShadelessFox
force-pushed
the
menuitem-separate-check-and-icon
branch
from
b1c3272 to
bf9203d
Compare
|
@DevCharly please let me know what you think and if I should change anything :^) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what FlatLaf does, as of now:
It doesn't play well with non-contrast icons and ones that occupy the entire region they're painted on.
This is what I managed to achieve:
Also, note that now the entire check/radio icon is painted instead of just the knob part. I quite like how it looks.
This behavior is disabled by default and can be enabled by setting the property
MenuItem.checkIconSeparatedtotrue.